Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-752

Use a faster Stack implementation in TCompactProtocol

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.2
    • 0.3
    • Java - Library
    • None

    Description

      TCompactProtocol currently uses a java.util.Stack of Shorts internally to manage its field id deltas. In some profiling, this seems to take more runtime than we'd like. It's probably due to the fact that we are boxing and unboxing the primitive shorts whenever we interact with the stack.

      Since we have pretty narrow needs for the stack, I think a purpose-built version could perform much better.

      Attachments

        1. thrift-752.patch
          7 kB
          Bryan Duxbury

        Activity

          People

            bryanduxbury Bryan Duxbury
            bryanduxbury Bryan Duxbury
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: