Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1383

publish-docs.sh might publish to current too early

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.1.3
    • 3.2.2
    • build-release
    • None

    Description

      In the standard release flow of things, the release manager runs `bin/publish-docs.sh` right before VOTE which means that `/current` gets updated at least 3 days before we announce the release.

      Maybe updating current should be a specific command?

      bin/publish-docs.sh --update userName
      

      Attachments

        Issue Links

          Activity

            dkuppitz Daniel Kuppitz added a comment -

            I think it's better to use a completely different script then.

            bin/update-current-docs.sh <username>
            

            This way we don't need to add a bunch of if's and else's in publish-docs.sh. The new script would only need to determine the current version and update the symlinks accordingly.

            dkuppitz Daniel Kuppitz added a comment - I think it's better to use a completely different script then. bin/update-current-docs.sh <username> This way we don't need to add a bunch of if's and else's in publish-docs.sh . The new script would only need to determine the current version and update the symlinks accordingly.

            +1

            spmallette Stephen Mallette added a comment - +1

            Removed as a requirement to fix from the 3.1.x line because this line will never trigger the update of "current".

            spmallette Stephen Mallette added a comment - Removed as a requirement to fix from the 3.1.x line because this line will never trigger the update of "current".
            githubbot ASF GitHub Bot added a comment -

            GitHub user dkuppitz opened a pull request:

            https://github.com/apache/tinkerpop/pull/396

            TINKERPOP-1383 publish-docs.sh might publish to current too early

            Added a separate script to update the "current" docs.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/apache/tinkerpop TINKERPOP-1383

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/tinkerpop/pull/396.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #396


            commit 7279689db5d38aaaf796192ac165fd099fc38515
            Author: Daniel Kuppitz <daniel_kuppitz@hotmail.com>
            Date: 2016-09-01T15:09:06Z

            Added a separate script to update the "current" docs.


            githubbot ASF GitHub Bot added a comment - GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/396 TINKERPOP-1383 publish-docs.sh might publish to current too early Added a separate script to update the "current" docs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1383 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/396.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #396 commit 7279689db5d38aaaf796192ac165fd099fc38515 Author: Daniel Kuppitz <daniel_kuppitz@hotmail.com> Date: 2016-09-01T15:09:06Z Added a separate script to update the "current" docs.
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/tinkerpop/pull/396

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/396
            githubbot ASF GitHub Bot added a comment -

            Github user dkuppitz commented on the issue:

            https://github.com/apache/tinkerpop/pull/396

            CTR'ed.

            githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/396 CTR'ed.

            People

              dkuppitz Daniel Kuppitz
              spmallette Stephen Mallette
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: