Uploaded image for project: 'MyFaces Trinidad'
  1. MyFaces Trinidad
  2. TRINIDAD-2486

SELECTOR OF KIND IMG[SRC*="/ADF/IMAGES/T.GIF"] BREAKS IF SKIN COMPRESSION IS ON

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.1.0-core
    • 2.1.1-core
    • Skinning
    • None

    Description

      With selector of kind X[attr = "foo.gif"] is used and skin compression is on, the generated css is malformed.

      The bug is that attribute set containing a "dot" in the syntax is not rendering correctly in the generated css when skin compression is on.

      The cause is that we look for "." to determine the beginning of a new selector and add that to be compressed. So when attribute set contains something like img[src*="/foo/bar/img.gif"], the code thinks that ".gif"]" part is a selector.

      The solution is to skip the attribute set which is mentioned in between square braces when processing selectors for compression.

      I also observed that the existing public method CSSGenerationUtils.getStyleClasses() should actually be renamed to CSSGenerationUtils.getNonNamespacedStyleClasses() to reflect exactly what it is doing. Also this is not part of published API as it is in "org.apache.myfaces.trinidadinternal.style.util". So we can change it.

      Attachments

        1. jira-2486-on-trunk.patch
          3 kB
          Anand V Nath

        Activity

          People

            andy.schwartz Andy Schwartz
            anand.v.nath@oracle.com Anand V Nath
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: