Uploaded image for project: 'MyFaces Trinidad'
  1. MyFaces Trinidad
  2. TRINIDAD-2510

make SkinTestCase more extendable

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1.0-core
    • 2.1.1-core
    • Skinning
    • None

    Description

      SkinTestCase which is part of trinidad-impl/test, works with TestSkin enum which does not offer flexibility. The change proposed is to add an overloaded method for visiting skins where the skin resource path can be passed as a String. This will enable test cases extending SkinTestCase to work with any skin of their choice.

      The proposed change is to add this method in SkinTestCase:
      /**

      • Performs a visit of all style sheet nodes in the specified test
      • skin. This overloaded method is useful in extending SkinTestCase to
      • create more test cases since TestSkin does not provide all the skins
      • that test needs.
        */
        protected final void visitStyleSheets(String skinResourcePath, StyleSheetVisitor visitor) { StyleSheetDocument document = SkinTestUtils.parseSkin(skinResourcePath); StyleSheetVisitUtils.visitStyleSheets(document.getStyleSheetsAsCollection(), visitor); }

      Attachments

        1. jira-2510-new.patch
          2 kB
          Anand V Nath
        2. jira-2510-modified.patch
          1 kB
          Anand V Nath
        3. jira-2510.patch
          1 kB
          Anand V Nath

        Activity

          People

            andy.schwartz Andy Schwartz
            anand.v.nath@oracle.com Anand V Nath
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: