Details
-
Improvement
-
Status: Resolved
-
Trivial
-
Resolution: Won't Fix
-
2.0
-
None
-
None
Description
If retaining VelocityViewServlet.handleRequest(req, res, ctx), then I would suggest moving fillContext(ctx, req) into it rather than leaving it in doRequest. This way it saves a "do nothing" method call if handleRequest is overridden (which it had to be when extending VelocityServlet) instead of overriding fillContext and getTemplate.