Uploaded image for project: 'Velocity Tools'
  1. Velocity Tools
  2. VELTOOLS-112

Suggestion to move VelocityViewServlet.fillContext into handleRequest

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Won't Fix
    • 2.0
    • None
    • VelocityView
    • None

    Description

      If retaining VelocityViewServlet.handleRequest(req, res, ctx), then I would suggest moving fillContext(ctx, req) into it rather than leaving it in doRequest. This way it saves a "do nothing" method call if handleRequest is overridden (which it had to be when extending VelocityServlet) instead of overriding fillContext and getTemplate.

      Attachments

        Activity

          People

            Unassigned Unassigned
            slslhale Steve Hale
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: