Uploaded image for project: 'Maven Wagon'
  1. Maven Wagon
  2. WAGON-292

wagon-ssh-external doesn't protect file names from shell variable expansion

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Won't Fix
    • 1.0-beta-2, 1.0-beta-3, 1.0-beta-4, 1.0-beta-5, 1.0-beta-6
    • None
    • wagon-ssh-external
    • None
    • Originally produced with wagon-1.0-beta-2, but no relevant code changes are apparent in wagon-1.0-beta-6

    Description

      When constructing SCP command line in ScpExternalWagon#executeScpCommand(...) file names are not processed in any way. Since the command is executed via a shell, the raw, correct file names are subject to shell variable expansion.

      This is problematic at least when wagon-ssh-external is used as deployment target in Hudson, whch apparently uses path names like groupId$artifactId in the path that to files that are to be deployed.

      Surrounding the file names with single quotes should enough to prevent expansion. Arguably this is something that should be done by the Plexus utility when argument contents are set with Arg.setFile(...), but it doesn't do that and Wagon doesn't use .setFile(...) anyway (and probably couldn't for the remote file).

      Attachments

        Activity

          People

            Unassigned Unassigned
            tazle Tuure Laurinolli
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: