Uploaded image for project: 'Maven Wagon'
  1. Maven Wagon
  2. WAGON-343

wagon-scp should remove target area prior to uploading/unzipping new content

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Won't Fix
    • 1.0
    • None
    • wagon-ssh-external
    • None
    • Maven 3.0.3
      maven-site-plugin:3.0-beta-3
    • Patch

    Description

      Similiar to the request captured in this issue (https://jira.codehaus.org/browse/MSITE-250), my problem is that our target area gets out of sync when we upload our site generated content frequently using CI. When files are moved/deleted, our site deployment target area becomes a hassle to keep correct because when noticed, we have to manually delete either old files, or the entire folder (because it's easier ) prior to deploying the site. I'd like it if the wagon-scp code could remove the files/subfolders in the target area prior to uploading.

      I looked at the code, and a easy fix, which I tested, is to update the ScpHelper.putDirectory() method (in wagon-ssh-common) to remove the contents of the folder prior to uploading/unzipping the new files:

      ...
      try
      {
      executor.executeCommand( "cd " + path + "; rm -rf * ");

      wagon.put( zipFile, getPath( destDir, zipFile.getName() ) );

      executor.executeCommand( "cd " + path + "; unzip -q -o " + zipFile.getName() + "; rm -f " + zipFile.getName() );

      zipFile.delete();
      ...

      I have attached the version of the file which I updated and tested, and below is what the output looks like with my simple test project.

      Password for dev@localhost: XXXXXX
      scp://localhost/tmp/site-deploy - Session: Opened
      Executing command: mkdir -p /tmp/site-deploy/.
      Executing command: cd /tmp/site-deploy/.; rm -rf *
      Executing command: mkdir -p /tmp/site-deploy/.
      Executing command: scp -t "/tmp/site-deploy/./wagon3163598898345372687.zip"
      Uploading: ./wagon3163598898345372687.zip to scp://localhost/tmp/site-deploy

      Attachments

        1. ScpHelper.java
          11 kB
          Harrouchy Jamal

        Issue Links

          Activity

            People

              Unassigned Unassigned
              jamal Harrouchy Jamal
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: