Uploaded image for project: 'Maven Wagon'
  1. Maven Wagon
  2. WAGON-495

Fix checkoutDirectory leak

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.0.0, 3.1.0
    • 3.1.0
    • wagon-scm
    • None

    Description

      During deploy artifacts to SVN an instance of ScmWagon is initialized and artifact metadata is downloaded to a local folder. After that maven tries to upload the jar file. ScmWagon.put(File,String) is called which internally overwrites the checkoutDirectory field and checks out the repo again to another temporary folder. The original folder is forgotten.

      Maven uploads jars, poms, checksums and for each file ScmWagon checks out a new directory.

      In the end the closeConnection() method is called which removes the last used folder.

      UPD: this causes false positive in testWagonPutDirectoryWhenDirectoryAlreadyExists(): the test deletes the test checkout dir before calling get(), but the wagon checkout dir remains and the file is retrieved from there.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. WAGON-503 Directory gives out of date error in putDirectory() to a non-empty Subversion repo

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. WAGON-501 Add ScmGitExeWagonTest

          • Major - Major loss of function.
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. WAGON-497 ScmWagon#put() strips parent dirs from the target path if they already exist in SCM

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. WAGON-498 ScmWagon should work in binary and shallow mode when possible

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #46

          Web Link GitHub Pull Request #46

          Activity

            People

              michael-o Michael Osipov
              basinilya Ilya Basin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: