Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-1718

WebPage#onAfterRender erroneously reports missing header

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.3.4
    • 1.4-RC2
    • wicket
    • None

    Description

      In WebPage#onAfterRender() there's a check wether a header was missing on a page and header contributions would be lost.

      In the following case this check erroneously barks:

      • page A was requested
      • in A's onBeforeRender() a RestartResponseAtInterceptPageException to page B is thrown
      • page A's onAfterRender() is invoked in a finally block
      • processing continues with page B

      Page A's onAfterRender() complains about the missing header, althought his page was never completely rendered.

      IMHO there's a check missing in WebPage#onAfterRender():

      if (getRequestCycle().getResponsePage() == this)

      { ..... }

      Or is Page A not allowed to throw RestartResponseAtInterceptPageException in onBeforeRender() at all?

      Attachments

        Issue Links

          Activity

            People

              jdonnerstag Juegen Donnerstag
              svenmeier Sven Meier
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: