Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5350

Enhancement for AbstractChoice and WildcardListModel API

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 6.10.0, 7.0.0-M1
    • 7.0.0-M4
    • None

    Description

      According to Efective Java book (http://devender.files.wordpress.com/2008/05/effectivejava.pdf), item 28:

      "No wildcard type for return value"

      Especially "User should not have to think about wildcards to use your API".

      so

      public List<? extends E> getChoices()

      should be changed to

      public List<E> getChoices()

      and for WildcardListModel

      protected List<? extends T> createSerializableVersionOf(List<? extends T> object)

      should be changed to

      protected List<T> createSerializableVersionOf(List<? extends T> object)

      Probably there is a lot of such things in framework.

      Attachments

        Issue Links

          Activity

            People

              svenmeier Sven Meier
              betlista Betlista
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: