Uploaded image for project: 'XMLGraphicsCommons'
  1. XMLGraphicsCommons
  2. XGC-43

[PATCH] Useless messages for exception thrown in Image codec

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Resolution: Fixed
    • 2.6
    • None
    • image codecs
    • Operating System: All
      Platform: All

    Description

      PropertyUtil references a non-existent resource bundle: "org.apache.xmlgraphics.image.codec.resources.Messages".

      The PropertyUtil class is used to generated localized message for the exception thrown in image.codec subpackages, and since the resource is not supplied, the generated exceptions messages are all useless (e.g. "PNGEncodeParam0").

      I propose to change the pattern of the message key, instead of using "classname + number", by using a "real" meaningful message, like "invalid value supplied".

      I will attach shortly:

      • A patch to PropertyUtil to be able to give arguments to the messages,
      • an enhancement of the messages for some classes in image.codec,
      • a resource bundle (for Locale "en" and "fr")

      Attachments

        1. PropertyUtil.diff
          2 kB
          Julien Aymé
        2. PNGEncodeParam.diff
          13 kB
          Julien Aymé
        3. PNGDecodeParam.diff
          1 kB
          Julien Aymé
        4. Messages_fr.properties
          0.5 kB
          Julien Aymé
        5. Messages_en.properties
          0.4 kB
          Julien Aymé

        Activity

          People

            general@xmlgraphics.apache.org XML Graphics Project Mailing List
            julien.ayme@gmail.com Julien Aymé
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: