Uploaded image for project: 'Yetus'
  1. Yetus
  2. YETUS-724

github diff vs. patch

    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.10.0
    • Precommit
    • None
    • Hide
      <!-- markdown -->
      precommit will now attempt to try both forms of git patches (binary format-patch and ASCII git diff) when working with Github PRs or Gitlab MRs. It will prefer the format-patch style due to accuracy, but will fallback to diff style if the former does not apply successfully.
      Show
      <!-- markdown --> precommit will now attempt to try both forms of git patches (binary format-patch and ASCII git diff) when working with Github PRs or Gitlab MRs. It will prefer the format-patch style due to accuracy, but will fallback to diff style if the former does not apply successfully.
    • Important

    Description

      Experience has shown that patch is more accurate diff. However, we could still try diff. Doing so would enable a lot more scenarios where unsquashed commits would work. Warn that reported line numbers and binary files may not be accurate as a result rather than just flat out failing... with the premise that some output is better than none.

      Attachments

        1. YETUS-724.02.patch
          22 kB
          Allen Wittenauer
        2. YETUS-724.01.patch
          22 kB
          Allen Wittenauer
        3. YETUS-724.00.patch
          20 kB
          Allen Wittenauer

        Issue Links

          breaks

          Bug - A problem which impairs or prevents the functions of the product. YETUS-882 command line patch files do not work in docker mode

          • Blocker - Blocks development and/or testing work, production could not run
          • Resolved
          contains

          Improvement - An improvement or enhancement to an existing feature or task. YETUS-151 reject multi-commit patches

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link GitHub Pull Request #29

          Activity

            People

              aw Allen Wittenauer
              aw Allen Wittenauer
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 50m
                  2h 50m