Uploaded image for project: 'Apache YuniKorn'
  1. Apache YuniKorn
  2. YUNIKORN-1732

Build fails due to brittle SHA calculation

    XMLWordPrintableJSON

Details

    Description

      When building the k8shim, the script used to calculate the SHA of various components is inconsistent and can fail the build if the SI or core are replaced with local components.

      ./scripts/plugin-conf-gen.sh /Users/ccondit/.kube/config "conf/scheduler-config.yaml" "conf/scheduler-config-local.yaml"
building binary for scheduler docker image
CGO_ENABLED=0 GOOS=linux GOARCH="amd64" \
	go build -a -o=_output/bin/k8s_yunikorn_scheduler -ldflags \
	'-extldflags "-static" -X main.version=latest -X main.date=2023-05-11T16:04:37-0500 -X main.goVersion=1.20.2 -X main.arch=amd64 -X main.coreSHA=20230328135225 -X main.siSHA=interface v0.0.0 -X main.shimSHA=0935a47ee430' \
	-tags netgo -installsuffix netgo \
	./pkg/cmd/shim/
# github.com/apache/yunikorn-k8shim/pkg/cmd/shim
usage: link [options] main.o
...
make: *** [scheduler] Error 1
command execution failed: build docker images failed

      The problematic portion:

      -X main.coreSHA=20230328135225 
-X main.siSHA=interface v0.0.0 
-X main.shimSHA=0935a47ee430

      The output is inconsistent, and in the case of the SI SHA, contains a space.

      Attachments

        Issue Links

          links to

          Web Link GitHub Pull Request #589

          Activity

            People

              ccondit Craig Condit
              ccondit Craig Condit
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: