Uploaded image for project: 'Apache YuniKorn'
  1. Apache YuniKorn
  2. YUNIKORN-1884

Fix documentation for allow-preemption flag

    XMLWordPrintableJSON

Details

    Description

      The `yunikorn.apache.org/allow-preemption` is an annotation key, but we put it in labels in e2e-test helper function [1]. We need to fix this.

       

      Another question is that we say `allow-preemption` can only be set on the PriorityClass in the document [2], but we check the key from Pod annotations first and then PriorityClass [3]. Do we want to update the document?

       

      [1] https://github.com/apache/yunikorn-k8shim/blob/ac8df7992c94b9b5c36b28452e2de1b5a050f373/test/e2e/framework/helpers/k8s/pod_conf.go#L91-L100

      [2] https://yunikorn.apache.org/docs/user_guide/labels_and_annotations_in_yunikorn#annotations-in-yunikorn

      [3] https://github.com/apache/yunikorn-k8shim/blob/ac8df7992c94b9b5c36b28452e2de1b5a050f373/pkg/cache/task.go#L251-L261

       

      Attachments

        Issue Links

          Activity

            People

              yangpoan PoAn Yang
              yangpoan PoAn Yang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: