Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2856

ZooKeeperSaslClient#respondToServer should log exception message of SaslException

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.4.10, 3.5.3
    • 3.4.11, 3.5.4, 3.6.0
    • None
    • None

    Description

      When upstream like HBase call ZooKeeperSaslClient with security enabled, we sometimes get error in HBase logs like:

      SASL authentication failed using login context 'Client'.
      

      This error occures when getting SaslException in ZooKeeperSaslClient#respondToServer :

       catch (SaslException e) {
                      LOG.error("SASL authentication failed using login context '" +
                              this.getLoginContext() + "'.");
                      saslState = SaslState.FAILED;
                      gotLastPacket = true;
        }
      

      This error makes user confused without explicit exception message. So I think we can add exception message to the log.

      Attachments

        1. ZOOKEEPER-2856-1.patch
          0.8 kB
          Pan Yuxuan

        Issue Links

          Activity

            People

              panyuxuan Pan Yuxuan
              panyuxuan Pan Yuxuan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: