Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2876

Github pull request test script should output -1 when there is no tests provided in patch, unless the subject under test is a documentation JIRA

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • build-infrastructure, tests
    • None

    Description

      The github pull request test script (which is invoked as part of pre-commit workflow) should output -1 on a patch which does not include any tests, unless the patch is a documentation only patch.

      We had this expected behavior before when we use the old PATCH approach:

          -1 tests included.  The patch doesn't appear to include any new or modified tests.
                              Please justify why no new tests are needed for this patch.
                              Also please list what manual steps were performed to verify this patch.
      

      A quick look on the script indicates that we do not set up the $PATCH/jira directory in the github test pull script, so it always thinks incoming pull request is a documentation only patch. This should be fixed so we get the old behavior and enforce that any new pull request must have tests unless explicitly justified not have to.

      Attachments

        Activity

          People

            Unassigned Unassigned
            hanm Michael Han
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: