Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-4651

Fix checkstyle problems on branch-3.6

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.6.4
    • None

    Description

      Checkstyle was upgraded to 8.39 in ZOOKEEPER-4644 and it doesn't work properly on current branch 3.6. Given that branch 3.6 won't be actively developed in the future, I decided to downgrade checkstyle back to 8.19 instead of fixing the checkstyle config or re-format the code.

      But even after downgrade, checkstyle fails on branch-3.6 with the following error. We need to fix it before release 3.6.4

      [INFO] There are 4 errors reported by Checkstyle 8.19 with checkstyle-strict.xml ruleset.
      [ERROR] src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[9] (javadoc) JavadocParagraph: <p> tag should be placed immediately before the first word, with no space after.
      [ERROR] src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[9] (javadoc) JavadocParagraph: <p> tag should be preceded with an empty line.
      [ERROR] src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[11] (javadoc) JavadocParagraph: <p> tag should be placed immediately before the first word, with no space after.
      [ERROR] src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java:[11] (javadoc) JavadocParagraph: <p> tag should be preceded with an empty line.
      
      (...)
      
       [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (default-cli) on project zookeeper-compatibility-tests-curator: You have 4 Checkstyle violations. -> [Help 1]
      
       

      Attachments

        Issue Links

          Activity

            People

              symat Mate Szalay-Beko
              symat Mate Szalay-Beko
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h