Uploaded image for project: 'Groovy'
  1. Groovy
  2. GROOVY-10248

Groovy ResolveVisitor runs twice

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 4.0.0-beta-2
    • Compiler
    • None

    Description

      CompilationUnit runs ResolveVisitor explicitly but the resolver is also registered as a regular PhaseOperation.

      It's not that big deal, as classes resolved in the 1st pass are relatively quickly determined as resolved. But still the whole AST source must be traversed.

      The ISourceUnitOperation's guard (check source.phase against unit.phase) does not work here, as the explicit resolver cannot upgrade the source's phase (not all operations completed).

      Attachments

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. GROOVY-8729 Eliminate the additional resolving phase of compilation for better performance

          • Major - Major loss of function.
          • Closed

          Technical Debt - GROOVY-10300 Rework runtime script member resolution

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              emilles Eric Milles
              sdedic Svatopluk Dedic
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h