Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-4160 Vectorized Query Execution in Hive
  3. HIVE-5309

Update hive-default.xml.template for vectorization flag; remove unused imports from MetaStoreUtils.java

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • vectorization-branch
    • vectorization-branch, 0.13.0
    • None
    • None

    Description

      This jira provides fixes for some of the review comments on HIVE-5283.
      1) Update hive-default.xml.template for vectorization flag.
      2) remove unused imports from MetaStoreUtils.
      3) Add a test to run vectorization with non-orc format. The test must still pass because vectorization optimization should fall back to non-vector mode.
      4) Hardcode the table name in QTestUtil.java.

      Attachments

        1. HIVE-5309.1.vectorization.patch
          6 kB
          Jitendra Nath Pandey
        2. HIVE-5309.1-vectorization.patch
          6 kB
          Jitendra Nath Pandey

        Issue Links

          Activity

            Renaming the patch file so that jenkins applies it to the right branch.

            jnp Jitendra Nath Pandey added a comment - Renaming the patch file so that jenkins applies it to the right branch.
            hiveqa Hive QA added a comment -

            Overall: -1 at least one tests failed

            Here are the results of testing the latest attachment:
            https://issues.apache.org/jira/secure/attachment/12603954/HIVE-5309.1-vectorization.patch

            ERROR: -1 due to 6 failed/errored test(s), 3955 tests executed
            Failed tests:

            org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input4
            org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_plan_json
            org.apache.hcatalog.cli.TestPermsGrp.testCustomPerms
            org.apache.hive.hcatalog.mapreduce.TestHCatExternalPartitioned.testHCatPartitionedTable
            org.apache.hive.hcatalog.mapreduce.TestHCatHiveCompatibility.testPartedRead
            org.apache.hive.hcatalog.mapreduce.TestHCatHiveCompatibility.testUnpartedReadWrite
            

            Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/815/testReport
            Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/815/console

            Messages:

            Executing org.apache.hive.ptest.execution.PrepPhase
            Executing org.apache.hive.ptest.execution.ExecutionPhase
            Executing org.apache.hive.ptest.execution.ReportingPhase
            Tests failed with: TestsFailedException: 6 tests failed
            

            This message is automatically generated.

            hiveqa Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12603954/HIVE-5309.1-vectorization.patch ERROR: -1 due to 6 failed/errored test(s), 3955 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input4 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_plan_json org.apache.hcatalog.cli.TestPermsGrp.testCustomPerms org.apache.hive.hcatalog.mapreduce.TestHCatExternalPartitioned.testHCatPartitionedTable org.apache.hive.hcatalog.mapreduce.TestHCatHiveCompatibility.testPartedRead org.apache.hive.hcatalog.mapreduce.TestHCatHiveCompatibility.testUnpartedReadWrite Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/815/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/815/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 6 tests failed This message is automatically generated.
            hiveqa Hive QA added a comment -

            Overall: -1 at least one tests failed

            Here are the results of testing the latest attachment:
            https://issues.apache.org/jira/secure/attachment/12603954/HIVE-5309.1-vectorization.patch

            ERROR: -1 due to 5 failed/errored test(s), 3955 tests executed
            Failed tests:

            org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input4
            org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_plan_json
            org.apache.hcatalog.listener.TestMsgBusConnection.testConnection
            org.apache.hive.hcatalog.listener.TestMsgBusConnection.testConnection
            org.apache.hive.hcatalog.mapreduce.TestHCatExternalPartitioned.testHCatPartitionedTable
            

            Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/820/testReport
            Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/820/console

            Messages:

            Executing org.apache.hive.ptest.execution.PrepPhase
            Executing org.apache.hive.ptest.execution.ExecutionPhase
            Executing org.apache.hive.ptest.execution.ReportingPhase
            Tests failed with: TestsFailedException: 5 tests failed
            

            This message is automatically generated.

            hiveqa Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12603954/HIVE-5309.1-vectorization.patch ERROR: -1 due to 5 failed/errored test(s), 3955 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input4 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_plan_json org.apache.hcatalog.listener.TestMsgBusConnection.testConnection org.apache.hive.hcatalog.listener.TestMsgBusConnection.testConnection org.apache.hive.hcatalog.mapreduce.TestHCatExternalPartitioned.testHCatPartitionedTable Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/820/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/820/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 5 tests failed This message is automatically generated.

            Committed to branch. Thanks, Jitendra!

            ashutoshc Ashutosh Chauhan added a comment - Committed to branch. Thanks, Jitendra!

            People

              jnp Jitendra Nath Pandey
              jnp Jitendra Nath Pandey
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: