Uploaded image for project: 'Maven Enforcer Plugin'
  1. Maven Enforcer Plugin
  2. MENFORCER-33

Tidy up EvaluateBeanshell rule

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 1.0-alpha-3
    • 1.0-alpha-4
    • Standard Rules
    • None
    • Patch

    Description

      The rule contains various local variables that are only used in some log statements and hence seem superfluos. If logging is the sole purpose of these lines, they should be enclosed in a block that is guarded by log.isDebugEnabled(). There is no need to slow the check or risk failures just for the fun of debug logging.

      Attachments

        1. eval-beanshell.patch
          3 kB
          Benjamin Bentmann

        Activity

          People

            brianf Brian E Fox
            bentmann Benjamin Bentmann
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: