Details
-
Bug
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
Description
yunseong have found a bug that NCS did not work correctly with deprecated methods. In REEF-610, we made NetworkConnectionService be able to register multiple identifiers by assigning different local end point identifier for every single NetworkConnectionFactory. So one container can be looked up by many identifiers that follow the form connectionFactoryId/localEndPointId.
For example, supposed that there are two evaluators A, B and two connection types Shuffle and GroupComm. Both Shuffle/A and GroupComm/A can represent the same evaluator A.
If some NetworkConnectionFactory are registered by deprecated methods, it should look up remoteEndPointId without connectionFactoryId. However, current NetworkConnectionFactory always looks up other container's address with connectionFactoryId/remoteEndPointId regardless of whether they are registered by deprecated methods, or not. We should change it to look up without connectionFactoryId if the NetworkConnectionFactory was registered by deprecated method.
Attachments
Issue Links
- blocks
-
REEF-637 Remove deprecated methods of NCS and mark as @Unstable
- Resolved
- links to