Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-9953

ACEs on/below user nodes are ignored upon conversion

    XMLWordPrintableJSON

Details

    Description

      I had a look at the cp-feature-model-converter in the light of SLING-9692 and found a surprising comment pointing to SLING-8561:

      // clean the unneeded ACLs, see SLING-8561

      code here:
      https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/acl/DefaultAclManager.java#L146-L153

      what it does in fact is omit any kind of permission setup that is defined for the service users home node. that's quite a serious bug IMHO.... and on top of that unnecessary because Sling repo-init allows to define those kind of ACEs using the home(userid) notation (see https://sling.apache.org/documentation/bundles/repository-initialization.html)

      and btw: what does unneeded ACLs mean? they are for sure not 'unneeded' and omitting them will essentially result in an invalid permission setup (and thus break the feature using the service login).

      cc: cziegeler, karlpauls, dsuess

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. SLING-9692 Add support for principal-based access control entries

          • Major - Major loss of function.
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. SLING-9959 SystemUser.getPath must reveal the path of the original user node

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. SLING-9966 Update dependency to org.apache.sling.repoinit.parser

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #51

          Web Link GitHub Pull Request #55

          Activity

            People

              karlpauls Karl Pauls
              angela Angela Schreiber
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: