Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-9959

SystemUser.getPath must reveal the path of the original user node

    XMLWordPrintableJSON

Details

    Description

      found the following repo-init statement to create system users:

      https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/acl/DefaultAclManager.java#L109

      which states:

      formatter.format("create service user %s with path %s%n", systemUser.getId(), systemUser.getPath());

      now.... i might be mistaken, but if my reading of the SystemUserParser is correct, the path defined with the SystemUser instance actually reflects the path of the system user node itself:

      https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/SystemUsersEntryHandler.java#L70-L75

      if that was true the repo-init statements would be wrong, because the path argument doesn't specify that path of the user node itself but rather the intermediate path to be used.

      so the statement should probably read:

      formatter.format("create service user %s with path %s%n", systemUser.getId(), systemUser.getParent().getPath());

       

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. SLING-9953 ACEs on/below user nodes are ignored upon conversion

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SLING-9969 UsersEntryHandler and GroupEntryHandler contain hardcoded users/groups home path and doesn't include system-rel-path

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SLING-9692 Add support for principal-based access control entries

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #40

          Activity

            People

              karlpauls Karl Pauls
              angela Angela Schreiber
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: