Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-9967

AclManagerTest.makeSureAclsAreCreatedOnlyoutsideSytemUsersPaths covers too many different scenarios

    XMLWordPrintableJSON

Details

    Description

      AclManagerTest.makeSureAclsAreCreatedOnlyoutsideSytemUsersPaths should be refactored to cover just a single test scenario (matching the name of the method)

      despite the name of the test method it not only asserts that entries effective below/at the user home node are ignored (see SLING-9953 for the corresponding bug), but also covers entries at arbitrary paths as well as quote // add an ACL for unknown user, which IMHO doesn't belong here.

      to make things more confusing it additional add quote // emulate a second iteration of conversion, which IMHO is not clear why this is relevant for the original intended scenario.

      this just make any kind of bug fix or improvement of the code base extra hard as the test has too many different ways of failing. also, if SLING-9953 is fixed and the test gets removed, the other (legitimate) test-scenarios will also be gone without replacement.

      Attachments

        Issue Links

          Activity

            People

              karlpauls Karl Pauls
              angela Angela Schreiber
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: